Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing config and make sure to use floats in example #3989

Merged
merged 2 commits into from
May 18, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented May 18, 2020

Proposed change(s)

The example configuration provided in Training-ML-Agents.md was missing the summary_freq field and formatted others (learning_rate) as strings when they should have been floats. Update the documentation with proper formatting and entries.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from chriselion May 18, 2020 18:18
@chriselion chriselion merged commit 38413ce into release_2_branch May 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-2-updateconfigexample branch May 18, 2020 19:54
chriselion pushed a commit that referenced this pull request May 21, 2020
* update versions for patch release (#3970)

* update versions for patch releae

* Update precommit flake8 (#3961)

* fix changelog

* Release 2 cherry pick (#3971)

* [bug-fix] Fix issue with initialize not resetting step count (#3962)

* Develop better error message for #3953 (#3963)

* Making the error for wrong number of agents raise consistently

* Better error message for inputs of wrong dimensions

* Fix #3932, stop the editor from going into a loop when a prefab is selected. (#3949)

* Minor doc updates to release

* add unit tests and fix exceptions (#3930)

Co-authored-by: Ervin T <ervin@unity3d.com>
Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
Co-authored-by: Chris Goy <christopherg@unity3d.com>

* update changelog (#3975)

* [docs] Add memory_size hyperparameter (#3973)

* Release 2 docs (#3976)

* Add v1.0 blog post and update reference paper. (#3947)

* Develop mm fix readme releases (#3966)

* Fix broken link and clean-up Releases section.

* Updated link to be consistent with the table.

* Update one of the bullets for consistency.

* update table, add Versioning doc

* release_2_docs

Co-authored-by: Marwan Mattar <marwan@unity3d.com>

* update barracuda to 0.7.1 (#3977)

* Wrong variable naming in code example (#3983) (#3988)

Co-authored-by: Sebastian Schuchmann <schuchmannsebastian@gmail.com>

* Fix barracuda version in changelog

* [docs] Add missing config and make sure to use floats in example (#3989)

* Add missing config and make sure to use floats in example

* Moved init_path

* fix typo in log message (#3987)

* Fix Barracuda assembly reference. (#3994)

* fix missing metafile (#3999)

* add missing metafile, change package to 1.0.2

* changelog

* undo DevProject

* Update make_readme_table.py

* reapply markdown config file changes

* fix release_1 references (#4001)

Co-authored-by: Ervin T <ervin@unity3d.com>
Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com>
Co-authored-by: Chris Goy <christopherg@unity3d.com>
Co-authored-by: Marwan Mattar <marwan@unity3d.com>
Co-authored-by: Sebastian Schuchmann <schuchmannsebastian@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants